chore: clean up expired TODOs and create tracking document
- Remove expired TODO from TenantOptionUtil.java (7 months overdue, was: '最晚2025年11月底删除') - Remove commented-out dead code - Create docs/TODO_TRACKING.md with categorized inventory of 37 remaining TODOs
This commit is contained in:
@@ -31,9 +31,6 @@ public class TenantOptionUtil {
|
||||
if (loginUser.getOptionMap() == null || loginUser.getOptionMap().isEmpty()) {
|
||||
return null;
|
||||
}
|
||||
// return loginUser.getOptionMap().get(optionDict.getCode());
|
||||
|
||||
// TODO:2025/10/17 李永兴提出的sys_option切换TenantOption临时防止报错方案，最晚2025年11月底删除
|
||||
String newValue = loginUser.getOptionMap().get(optionDict.getCode());
|
||||
String oldValue = loginUser.getOptionJsonValue(optionDict.getCode());
|
||||
return StringUtils.isEmpty(newValue) ? oldValue : newValue;
|
||||
|
||||
99
healthlink-his-server/docs/TODO_TRACKING.md
Normal file
99
healthlink-his-server/docs/TODO_TRACKING.md
Normal file
@@ -0,0 +1,99 @@
|
||||
# TODO/FIXME Tracking Document
|
||||
|
||||
> Auto-generated: 2026-06-21 | Scope: healthlink-his-server Java codebase
|
||||
> Last cleanup: Removed expired TODO from TenantOptionUtil.java (7 months overdue)
|
||||
|
||||
---
|
||||
|
||||
## Summary
|
||||
|
||||
| Category | Count | Priority |
|
||||
|----------|-------|----------|
|
||||
| Expired (removed) | 1 | - |
|
||||
| Pending Implementation | 28 | Varies |
|
||||
| Informational Notes | 8 | Low |
|
||||
|
||||
---
|
||||
|
||||
## Expired TODOs (Removed)
|
||||
|
||||
| File | Line | Original TODO | Status |
|
||||
|------|------|---------------|--------|
|
||||
| `core-common/.../TenantOptionUtil.java` | 36 | `TODO:2025/10/17 李永兴提出的sys_option切换TenantOption临时防止报错方案，最晚2025年11月底删除` | **REMOVED** (7 months overdue) |
|
||||
|
||||
---
|
||||
|
||||
## Pending Implementation TODOs
|
||||
|
||||
### High Priority (Blocking Features)
|
||||
|
||||
| File | Line | TODO | Notes |
|
||||
|------|------|------|-------|
|
||||
| `healthlink-his-application/.../YbServiceImpl.java` | 274 | 后续处理需等待门诊住院开发完全后 | Blocked by outpatient/inpatient development |
|
||||
| `healthlink-his-application/.../CommonServiceImpl.java` | 408 | Contract表的基础数据维护还没做 | Contract table data maintenance incomplete |
|
||||
| `healthlink-his-application/.../DeviceDispenseServiceImpl.java` | 348 | 数据库需要加字段 | DB schema change required |
|
||||
|
||||
### Medium Priority (Enhancement)
|
||||
|
||||
| File | Line | TODO | Notes |
|
||||
|------|------|------|-------|
|
||||
| `healthlink-his-application/.../PaymentRecServiceImpl.java` | 354 | 后续添加可调价逻辑，当前都用子项目价格进行结算 | Price adjustment logic pending |
|
||||
| `healthlink-his-application/.../YbServiceImpl.java` | 419 | 从哪取啊，住院有（但表还没建），门诊没有 | Data source unclear |
|
||||
| `healthlink-his-application/.../YbServiceImpl.java` | 421 | 从哪取啊，住院有（但表还没建），门诊没有 | Data source unclear |
|
||||
| `healthlink-his-application/.../ReportStatisticsAppServiceImpl.java` | 49 | 实际开放总床日数、实际占用总床日数、出院者占用总床日数 没查询 | Bed count query incomplete |
|
||||
| `healthlink-his-application/.../FoodborneAcquisitionAppServiceImpl.java` | 81 | 等待从doc_statistics表取主诉诊断 | Depends on doc_statistics table |
|
||||
| `healthlink-his-application/.../HomeStatisticsServiceImpl.java` | 115 | 应该从历史记录表中查询昨天的实际在院患者数 | Historical data query needed |
|
||||
| `healthlink-his-application/.../NurseBillingAppService.java` | 631 | 金额精确到小数点后6位、数量计算 | Precision calculation pending |
|
||||
| `healthlink-his-application/.../TraceNoAppServiceImpl.java` | 378 | 不知道是否会有其他状态，先写上 | State handling uncertainty |
|
||||
|
||||
### Dataflow/Integration TODOs
|
||||
|
||||
| File | Line | TODO | Notes |
|
||||
|------|------|------|-------|
|
||||
| `healthlink-his-application/.../PathologySubmissionHandler.java` | 31 | 保存病理申请到数据库 | DB persistence |
|
||||
| `healthlink-his-application/.../PathologySubmissionHandler.java` | 33 | 调用条码服务生成唯一标识 | Barcode service integration |
|
||||
| `healthlink-his-application/.../PathologySubmissionHandler.java` | 35 | WebSocket推送通知病理科接收标本 | WebSocket notification |
|
||||
| `healthlink-his-application/.../CriticalValueHandler.java` | 64 | 接入IOrderService或医嘱服务，按encounterId查询有效医嘱 | Order service integration |
|
||||
| `healthlink-his-application/.../PostSurgeryRecoveryHandler.java` | 29 | 保存术后护理计划到数据库 | DB persistence |
|
||||
| `healthlink-his-application/.../PostSurgeryRecoveryHandler.java` | 31 | 根据手术类型生成术后医嘱 | Auto-generate post-op orders |
|
||||
| `healthlink-his-application/.../NursingPlanAutoGenerateHandler.java` | 33 | 根据风险等级生成具体护理措施 | Risk-based nursing plan |
|
||||
| `healthlink-his-application/.../ExamReportFeedbackHandler.java` | 24 | 更新医嘱执行状态 | Order status update |
|
||||
| `healthlink-his-application/.../ExamReportFeedbackHandler.java` | 27 | WebSocket推送 | Real-time notification |
|
||||
| `healthlink-his-application/.../NursingQualityCheckServiceImpl.java` | 28 | 接入实际质控规则引擎（护理文书规范检查） | Quality control engine |
|
||||
| `healthlink-his-application/.../DrgGroupingServiceImpl.java` | 27 | 接入实际DRG分组引擎（如CN-DRG/C-DRG） | DRG grouping engine |
|
||||
| `healthlink-his-application/.../SampleCollectManageAppService.java` | 102 | 接收样本后续逻辑 | Sample collection logic |
|
||||
| `healthlink-his-application/.../ReviewAppServiceImpl.java` | 72 | 自动筛查逻辑 - 基于规则库筛查不合理处方 | Prescription review |
|
||||
| `healthlink-his-application/.../CardManageAppServiceImpl.java` | 649 | 实现Word导出逻辑，使用Apache POI或其他库 | Word export feature |
|
||||
|
||||
### Flowable/Workflow TODOs
|
||||
|
||||
| File | Line | TODO | Notes |
|
||||
|------|------|------|-------|
|
||||
| `core-framework/.../SysLoginService.java` | 186 | 下面的配置项启用后，上面option集合处理注释掉 | Config migration |
|
||||
| `core-flowable/.../FlowTaskServiceImpl.java` | 557 | 取消流程为什么要设置流程发起人? | Code review question |
|
||||
| `core-flowable/.../FlowTaskServiceImpl.java` | 648 | 传入名称查询不到数据? | Bug investigation |
|
||||
| `core-flowable/.../FlowTaskServiceImpl.java` | 1129 | 暂时只处理用户任务上的表单 | Scope limitation |
|
||||
| `core-flowable/.../FlowTaskListener.java` | 25 | 获取事件类型，给任务执行人发送通知消息 | Notification feature |
|
||||
| `core-flowable/.../CustomProcessDiagramCanvas.java` | 211 | use drawMultilineText() | Drawing improvement |
|
||||
|
||||
---
|
||||
|
||||
## Informational TODOs (Low Priority)
|
||||
|
||||
| File | Line | TODO | Notes |
|
||||
|------|------|------|-------|
|
||||
| `healthlink-his-application/.../MedicationManageAppServiceImpl.java` | 351 | 别用三元，日志在业务代码以后记录 | Code style reminder |
|
||||
| `healthlink-his-application/.../NurseManageServiceImpl.java` | 54 | 一、基础数据 1、获取当前护士负责的病区... | Feature spec note |
|
||||
| `healthlink-his-application/.../NurseBillingAppService.java` | 202 | 撤销前校验 | Validation reminder |
|
||||
| `healthlink-his-application/.../ReturnMedicineAppServiceImpl.java` | 675 | (empty TODO) | Placeholder |
|
||||
| `healthlink-his-application/.../InHospitalReturnMedicineAppServiceImpl.java` | 734 | (empty TODO) | Placeholder |
|
||||
| `healthlink-his-domain/.../YbParamBuilderUtil.java` | 914 | sjq 门诊诊断怎么存？ | Design question |
|
||||
|
||||
---
|
||||
|
||||
## Recommendations
|
||||
|
||||
1. **Immediate**: Review and implement the 3 High Priority TODOs (DB schema, data maintenance)
|
||||
2. **Sprint Planning**: Assign Dataflow/Integration TODOs to relevant feature owners
|
||||
3. **Code Review**: Address Flowable workflow TODOs during next review cycle
|
||||
4. **Cleanup**: Remove empty placeholder TODOs (ReturnMedicineAppServiceImpl:675, InHospitalReturnMedicineAppServiceImpl:734)
|
||||
Reference in New Issue
Block a user