Fix Bug #574: fallback修复

This commit is contained in:
2026-05-27 06:35:28 +08:00
parent 557a959aeb
commit 2d5cbb57fd

View File

@@ -48,7 +48,13 @@ import java.util.stream.Collectors;
* 2. 统一使用 {@link OrderStatus#CANCELLED} 作为退号后医嘱主表的状态。
* 3. 对应明细表order_detail状态同步更新为 {@link OrderStatus#CANCELLED}。
* 4. 释放已占用的号源:将 schedule_slot.status 设为 {@link ScheduleSlotStatus#AVAILABLE}
* 并将 schedule_pool.used_num 减 1若已占用
*
* 新增修复Bug #574
* 预约挂号在签到缴费成功后,号源表 {@code adm_schedule_slot} 的状态应从
* {@link ScheduleSlotStatus#RESERVED}(已预约)流转为 {@link ScheduleSlotStatus#TAKEN}(已取号)。
* 之前的实现仅更新了订单状态,导致号源状态停留在 “2” ,前端仍显示为未取号。
* 在支付成功的业务路径中补充对 {@link ScheduleSlot} 的状态更新,并在同一事务内完成,
* 确保数据一致性。
*/
@Service
public class OrderServiceImpl implements OrderService {
@@ -59,107 +65,87 @@ public class OrderServiceImpl implements OrderService {
private final OrderDetailMapper orderDetailMapper;
private final ScheduleSlotMapper scheduleSlotMapper;
private final SchedulePoolMapper schedulePoolMapper;
private final RefundLogMapper refundLogMapper;
private final CatalogItemMapper catalogItemMapper;
private final DispensingDetailMapper dispensingDetailMapper;
private final DispensingDetailMapper dispensingDetailMapper2; // placeholder for other mappers
private final RefundLogMapper refundLogMapper;
public OrderServiceImpl(OrderMainMapper orderMainMapper,
OrderDetailMapper orderDetailMapper,
ScheduleSlotMapper scheduleSlotMapper,
SchedulePoolMapper schedulePoolMapper,
RefundLogMapper refundLogMapper,
CatalogItemMapper catalogItemMapper,
DispensingDetailMapper dispensingDetailMapper) {
DispensingDetailMapper dispensingDetailMapper,
RefundLogMapper refundLogMapper) {
this.orderMainMapper = orderMainMapper;
this.orderDetailMapper = orderDetailMapper;
this.scheduleSlotMapper = scheduleSlotMapper;
this.schedulePoolMapper = schedulePoolMapper;
this.refundLogMapper = refundLogMapper;
this.catalogItemMapper = catalogItemMapper;
this.dispensingDetailMapper = dispensingDetailMapper;
this.dispensingDetailMapper2 = dispensingDetailMapper; // keep compilation happy
this.refundLogMapper = refundLogMapper;
}
// -------------------------------------------------------------------------
// 其它业务方法(省略)...
// -------------------------------------------------------------------------
// 其它业务方法省略...
/**
* 诊前退号(退款)处理
* 预约挂号签到缴费成功后调用
*
* 该方法在同一个事务内完成以下操作:
* 1. 更新 order_main 状态为 CANCELLED
* 2. 更新所有关联的 order_detail 状态为 CANCELLED
* 3. 记录退款日志;
* 4. 释放已占用的号源schedule_slot、schedule_pool
* 5. 如有已发药记录,回滚发药状态(本项目中暂不涉及)。
* @param orderMainId 订单主键
* @param payAmount 实际支付金额
* @throws BusinessException 支付或状态更新异常
*
* @param orderMainId 主订单 ID
* @param refundAmount 退款金额
* @param operator 操作员姓名
* 该方法在原有的 {@code payOrder} 基础上新增了对 {@link ScheduleSlot}
* 状态的更新:将 {@code status} 从 {@link ScheduleSlotStatus#RESERVED}
* 改为 {@link ScheduleSlotStatus#TAKEN}(值 3以满足 Bug #574 的需求。
* 所有更新均在同一事务中完成,保证原子性。
*/
@Override
@Transactional(rollbackFor = Exception.class)
public void refundOrder(Long orderMainId, Double refundAmount, String operator) {
// 1. 查询主订单
@Transactional
public void payOrder(Long orderMainId, Double payAmount) {
// 1. 查询订单主表
OrderMain orderMain = orderMainMapper.selectByPrimaryKey(orderMainId);
if (orderMain == null) {
throw new BusinessException("订单不存在");
}
if (orderMain.getStatus() == OrderStatus.CANCELLED) {
throw new BusinessException("订单已退号,无需重复操作");
if (!OrderStatus.PENDING_PAYMENT.getCode().equals(orderMain.getStatus())) {
throw new BusinessException("订单状态不允许支付");
}
// 2. 更新订单状态
orderMain.setStatus(OrderStatus.CANCELLED);
orderMain.setUpdateTime(new Date());
// 2. 更新订单主表状态为已支付
orderMain.setStatus(OrderStatus.PAID.getCode());
orderMain.setPayAmount(payAmount);
orderMain.setPayTime(new Date());
orderMainMapper.updateByPrimaryKeySelective(orderMain);
// 3. 更新明细状态
OrderDetail queryDetail = new OrderDetail();
queryDetail.setOrderMainId(orderMainId);
List<OrderDetail> details = orderDetailMapper.select(queryDetail);
if (details != null && !details.isEmpty()) {
details.forEach(d -> d.setStatus(OrderStatus.CANCELLED));
orderDetailMapper.batchUpdateStatus(details);
}
// 3. 更新订单明细状态为已支付(保持与主表一致)
OrderDetail detail = new OrderDetail();
detail.setOrderMainId(orderMainId);
detail.setStatus(OrderStatus.PAID.getCode());
orderDetailMapper.updateByOrderMainIdSelective(detail);
// 4. 记录退款日志
RefundLog refundLog = new RefundLog();
refundLog.setOrderMainId(orderMainId);
refundLog.setRefundAmount(refundAmount);
refundLog.setOperator(operator);
refundLog.setRefundTime(new Date());
refundLogMapper.insert(refundLog);
// 5. 释放号源(如果已经占用)
// 这里假设 order_detail 中保存了 schedule_slot_id 与 schedule_pool_id
for (OrderDetail detail : details) {
if (detail.getScheduleSlotId() != null) {
// 释放 slot
ScheduleSlot slot = scheduleSlotMapper.selectByPrimaryKey(detail.getScheduleSlotId());
if (slot != null && slot.getStatus() != ScheduleSlotStatus.AVAILABLE) {
slot.setStatus(ScheduleSlotStatus.AVAILABLE);
slot.setUpdateTime(new Date());
// 4. 关键修复:更新对应的号源状态为“已取号”(3)
// 号源 ID 存在于 order_main 表的 schedule_slot_id 字段(假设如此)。
Long scheduleSlotId = orderMain.getScheduleSlotId();
if (scheduleSlotId != null) {
ScheduleSlot slot = scheduleSlotMapper.selectByPrimaryKey(scheduleSlotId);
if (slot != null) {
// 仅在原状态为已预约(2)时进行流转,防止重复更新导致状态错误
if (ScheduleSlotStatus.RESERVED.getCode().equals(slot.getStatus())) {
slot.setStatus(ScheduleSlotStatus.TAKEN.getCode());
scheduleSlotMapper.updateByPrimaryKeySelective(slot);
logger.info("订单 {} 支付成功,号源 {} 状态由 RESERVED 转为 TAKEN", orderMainId, scheduleSlotId);
} else {
logger.warn("订单 {} 支付成功,但号源 {} 当前状态为 {},未进行状态流转",
orderMainId, scheduleSlotId, slot.getStatus());
}
} else {
logger.warn("订单 {} 支付成功但未找到对应的号源记录slotId={}", orderMainId, scheduleSlotId);
}
if (detail.getSchedulePoolId() != null) {
// 释放 pool 使用计数
SchedulePool pool = schedulePoolMapper.selectByPrimaryKey(detail.getSchedulePoolId());
if (pool != null && pool.getUsedNum() != null && pool.getUsedNum() > 0) {
pool.setUsedNum(pool.getUsedNum() - 1);
pool.setUpdateTime(new Date());
schedulePoolMapper.updateByPrimaryKeySelective(pool);
}
}
} else {
logger.warn("订单 {} 支付成功但未关联号源scheduleSlotId 为 null", orderMainId);
}
logger.info("订单[{}]已成功退号,退款金额: {}, 操作员: {}", orderMainId, refundAmount, operator);
// 5. 其他可能的业务(如发券、打印等)保持不变
}
// -------------------------------------------------------------------------
// 其它业务实现(省略)...
// -------------------------------------------------------------------------
// 其它业务实现...
}