Compare commits

...

4 Commits

Author SHA1 Message Date
ed938becb3 Fix Bug #538: [门诊医生站-医嘱/手术申请] 手术申请单删除后级联删除关联医嘱、收费项目、申请单
根因:deleteSurgery 仅删除 cli_surgery 表记录,未级联删除关联的
wor_service_request(手术医嘱)、fin_charge_item(收费项目)、
doc_request_form(申请单),导致手术删除后医嘱列表仍存在对应记录。

修复:在 deleteSurgery 中先删除三张关联表数据,再删除手术记录,
所有操作在同一事务内保证一致性。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-18 11:05:14 +08:00
Ranyunqiao
a89d91c5be bug 443 522 523 2026-05-18 11:05:14 +08:00
af9b3bbc76 Fix Bug #537: 根因+修复方案摘要 2026-05-18 11:05:14 +08:00
fd16daa2a6 Fix Bug #537: [住院医生工作站] 冗余功能显示需在医生工作站页签中屏蔽汇总发药申请模块(仅修复代码,不改禅道状态和分配)
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-18 11:05:14 +08:00
8 changed files with 169 additions and 33 deletions

View File

@@ -0,0 +1,37 @@
# Bug #529 分析报告
## Title
[住院医生工作站-检验申请] 点击"修改"打开编辑弹窗后,原已选中的项目未回显
## 根因分析
### 数据流
1. `testApplication.vue` 列表中点击"修改" → `handleEdit(row)` 设置 `editRowData = row` → 打开编辑弹窗
2. 弹窗使用 `destroy-on-close`,每次打开都重新创建 `LaboratoryTests` 组件
3. `LaboratoryTests` 组件通过 `:editData="editRowData"` 接收编辑数据
### 根因时序竞态Race Condition
`laboratoryTests.vue` 中:
1. **`onMounted()`** (line 262) 调用 `loadAllData()` 异步加载检验项目列表到 `applicationListAll.value`
2. **watch on `props.editData`** (line 347-382) 设置了 `{ immediate: true }`,组件创建时立即触发
3. watch 内部line 369-377遍历 `requestFormDetailList`,在 `applicationListAll.value` 中按 `adviceName` 匹配已选项目
**时序问题**
- watch 因 `immediate: true` 立即触发时,`applicationListAll.value` 还是空数组 `[]``onMounted``loadAllData()` 尚未完成)
- 匹配逻辑找不到任何匹配项 → `transferValue.value = []`
- 随后 `loadAllData()` 完成,`applicationListAll.value` 被填充,但 watch 不会重新触发(因为 `props.editData` 没变化)
- 结果transfer 组件的 "已选择" 区域显示"无数据"
### 涉及文件
- **前端**: `openhis-ui-vue3/src/views/inpatientDoctor/home/components/order/applicationForm/laboratoryTests.vue` (line 347-382)
- **前端**: `openhis-ui-vue3/src/views/inpatientDoctor/home/components/applicationShow/testApplication.vue` (line 193-210, 弹窗渲染处)
### 修复方案
`laboratoryTests.vue` 中新增一个 watch 监听 `applicationListAll.value` 的变化,当数据加载完成且当前处于编辑模式时,重新执行回显匹配逻辑。这样确保:
- 编辑模式 watch 先触发(但匹配不到数据,因为 `applicationListAll` 为空)
- `applicationListAll` 加载完成后,新增 watch 触发,重新执行匹配,成功回显
改动量:约 12 行新增代码

View File

@@ -66,3 +66,15 @@
- Lint检查: 无新增错误均为已有pre-existing warnings
**修复结果:✅ 成功纯删除死代码无新增逻辑0个新lint错误**
## 2026-05-18 第三次复核(代码审计确认无需改动)
经全面代码审计确认:
- `inpatientDoctor/home/index.vue` 标签页列表: 仅8个正常标签页住院病历、诊断录入、临床医嘱、检验申请、检查申请、手术申请、输血申请、报告查询无"汇总发药申请"
- `inpatientNurse/constants/navigation.js`: 6个护士导航项无"汇总发药申请"
- `openhis-ui-vue3` 全目录搜索 `汇总发药申请`: 仅1处API注释`drug/inpatientMedicationDispensing/components/api.js`,药房模块,非医生界面)
- 全目录搜索 `SummaryDrug`/`summaryDrug`: 0个匹配
- 路由表无 `medicine-summary`/`medicineSummary` 相关入口
- 工作树状态: clean无需额外提交
**结论: 修复已在之前3次提交bfe544cf + 4809b357 + e6a61ea5中完成并推送到远程当前代码无残留。无需任何额外改动。**

View File

@@ -507,6 +507,7 @@ public class SurgeryAppServiceImpl implements ISurgeryAppService {
* @return 结果
*/
@Override
@Transactional(rollbackFor = Exception.class)
public R<?> deleteSurgery(Long id) {
// 校验手术是否存在
Surgery existSurgery = surgeryService.getById(id);
@@ -519,6 +520,28 @@ public class SurgeryAppServiceImpl implements ISurgeryAppService {
return R.fail("已完成的手术不能删除");
}
// 级联删除关联数据
String surgeryNo = existSurgery.getSurgeryNo();
// 1. 删除手术医嘱wor_service_request
LambdaQueryWrapper<ServiceRequest> serviceRequestWrapper = new LambdaQueryWrapper<>();
serviceRequestWrapper.eq(ServiceRequest::getActivityId, id);
serviceRequestService.remove(serviceRequestWrapper);
log.info("删除手术关联的医嘱 - surgeryId: {}, surgeryNo: {}", id, surgeryNo);
// 2. 删除收费项目fin_charge_item
LambdaQueryWrapper<ChargeItem> chargeItemWrapper = new LambdaQueryWrapper<>();
chargeItemWrapper.eq(ChargeItem::getProductId, id)
.eq(ChargeItem::getProductTable, "cli_surgery");
chargeItemService.remove(chargeItemWrapper);
log.info("删除手术关联的收费项目 - surgeryId: {}, surgeryNo: {}", id, surgeryNo);
// 3. 删除申请单doc_request_form
LambdaQueryWrapper<RequestForm> requestFormWrapper = new LambdaQueryWrapper<>();
requestFormWrapper.eq(RequestForm::getPrescriptionNo, surgeryNo);
requestFormService.remove(requestFormWrapper);
log.info("删除手术关联的申请单 - surgeryId: {}, surgeryNo: {}", id, surgeryNo);
surgeryService.deleteSurgery(id);
// 清除相关缓存

View File

@@ -559,9 +559,11 @@ public class DoctorStationAdviceAppServiceImpl implements IDoctorStationAdviceAp
if (adviceSaveList != null && !adviceSaveList.isEmpty()) {
for (int i = 0; i < adviceSaveList.size(); i++) {
AdviceSaveDto dto = adviceSaveList.get(i);
log.info("Request[{}]: requestId={}, dbOpType={}, adviceType={}, encounterId={}, patientId={}",
i, dto.getRequestId(), dto.getDbOpType(), dto.getAdviceType(),
dto.getEncounterId(), dto.getPatientId());
log.info("Request[{}]: requestId={}, dbOpType={}, adviceType={}, encounterId={}, patientId={}, categoryEnum={}, categoryEnum.class={}, categoryCode={}, categoryCode.class={}",
i, dto.getRequestId(), dto.getDbOpType(), dto.getAdviceType(),
dto.getEncounterId(), dto.getPatientId(),
dto.getCategoryEnum(), dto.getCategoryEnum() != null ? dto.getCategoryEnum().getClass().getName() : "NULL",
dto.getCategoryCode(), dto.getCategoryCode() != null ? dto.getCategoryCode().getClass().getName() : "NULL");
}
}
@@ -1562,7 +1564,7 @@ public class DoctorStationAdviceAppServiceImpl implements IDoctorStationAdviceAp
// 🔧 BugFix #498: categoryEnum=22(检查) 走 ServiceRequest不走 DeviceRequest
// 检查申请单的诊疗定义ID存在 activityId不在 adviceDefinitionId
// deviceDefId 对应耗材定义ID不能用诊疗定义ID填充
if (adviceSaveDto.getCategoryEnum() == 22) {
if (Integer.valueOf(22).equals(adviceSaveDto.getCategoryEnum())) {
log.info("handDevice skip - 检查申请单(categoryEnum=22) 走 ServiceRequest 路径,跳过 DeviceRequest 保存");
continue; // 跳过本次循环,不走耗材请求路径
} else if (adviceSaveDto.getAdviceDefinitionId() != null) {

View File

@@ -3801,6 +3801,8 @@ function handleSaveHistory(value) {
uniqueKey: undefined,
dbOpType: value.requestId ? '2' : '1',
minUnitQuantity: value.quantity * value.partPercent,
// 🔧 修复:确保 categoryEnum 被传递(耗材必填字段),避免后端 NPE
categoryEnum: value.categoryEnum || value.categoryCode,
conditionId: conditionId.value,
conditionDefinitionId: conditionDefinitionId.value,
encounterDiagnosisId: encounterDiagnosisId.value,

View File

@@ -63,7 +63,7 @@
<span class="medicine-info"> 诊断{{ config.diagnosisName }} </span>
<span class="medicine-info"> 皮试{{ row.skinTestFlag_enumText }} </span>
<span class="medicine-info"> 注射药品{{ row.injectFlag_enumText }} </span>
<span class="total-amount" v-if="row.therapyEnum == '2'">
<span class="total-amount">
总金额{{ row.totalPrice ? Number(row.totalPrice).toFixed(2) + ' 元' : '0.00 元' }}
</span>
</div>
@@ -83,7 +83,7 @@
:controls="false"
style="width: 70px"
:ref="(el) => setInputRef('doseQuantity', el)"
@input="convertValues"
@input="() => { convertValues(); calculateTotalAmount(); }"
@keyup.enter.prevent="handleEnter('doseQuantity')"
/>
</el-form-item>
@@ -110,7 +110,7 @@
:controls="false"
style="width: 70px; margin-left: 32px"
:ref="(el) => setInputRef('dose', el)"
@input="convertDoseValues"
@input="() => { convertDoseValues(); calculateTotalAmount(); }"
@keyup.enter.prevent="handleEnter('dose')"
/>
</el-form-item>
@@ -119,7 +119,7 @@
v-model="row.doseUnitCode"
style="width: 70px"
placeholder=" "
@change="convertValues"
@change="() => { convertValues(); calculateTotalAmount(); }"
>
<el-option
v-for="item in row.unitCodeList"
@@ -271,13 +271,17 @@
controls-position="right"
:controls="false"
:ref="(el) => setInputRef('firstDose', el)"
@input="calculateTotalAmount"
@keyup.enter.prevent="handleEnter('firstDose')"
/>
</el-form-item>
<el-select v-model="row.unitCode" style="width: 70px" placeholder=" ">
<template v-for="item in row.unitCodeList" :key="item.value">
<el-option v-if="checkUnit(item)" :value="item.value" :label="item.label" />
</template>
<el-select v-model="row.doseUnitCode" style="width: 70px" placeholder=" ">
<el-option
v-for="item in row.unitCodeList"
:value="item.value"
:label="item.label"
:key="item.value"
/>
</el-select>
</template>
</div>
@@ -426,6 +430,7 @@
<script setup lang="ts">
import {computed, getCurrentInstance, nextTick, onMounted, ref, watch} from 'vue';
import Decimal from 'decimal.js';
interface Config {
diagnosisName: string; // 仅用于显示
@@ -623,7 +628,18 @@ const orgFallbackOption = (value: any) => {
const convertValues = () => props.handlers.convertValue('doseQuantity', props.row, props.index);
const convertDoseValues = () => props.handlers.convertValue('dose', props.row, props.index);
const calculateTotalPrice = () => props.handlers.calculateTotal('price', props.row, props.index);
const calculateTotalAmount = () => props.handlers.calculateTotal('amount', props.row, props.index);
// 直接用 row 计算总金额:数量 * 单价,避免父组件索引不匹配的问题
const calculateTotalAmount = () => {
nextTick(() => {
const row = props.row;
const qty = new Decimal(row.doseQuantity || 0);
const isMinUnit = row.unitCode == row.minUnitCode;
const price = isMinUnit ? row.minUnitPrice : row.unitPrice;
// 四舍五入到2位再算与页面显示的单价一致
const roundedPrice = new Decimal(price || 0).toDecimalPlaces(2, Decimal.ROUND_HALF_UP);
row.totalPrice = qty.mul(roundedPrice).toFixed(6);
});
};
const setInputRef = props.handlers.setInputRef;
defineExpose({

View File

@@ -605,13 +605,26 @@ function getListInfo(addNewRow) {
prescriptionList.value = res.data
.map((item) => {
const parsedContent = JSON.parse(item.contentJson);
// 构造 unitCodeList确保编辑时下拉框有正确的选项
console.log('【DEBUG】unitCode:', parsedContent?.unitCode, typeof parsedContent?.unitCode, 'unitCodeList:', JSON.stringify(parsedContent?.unitCodeList));
const unitCodeListData = parsedContent?.unitCodeList || [
{ value: String(parsedContent?.unitCode ?? item.unitCode ?? ''), label: parsedContent?.unitCode_dictText ?? item.unitCode_dictText ?? '', type: 'unit' },
{ value: String(parsedContent?.doseUnitCode ?? ''), label: parsedContent?.doseUnitCode_dictText ?? '', type: 'dose' },
{ value: String(parsedContent?.minUnitCode ?? ''), label: parsedContent?.minUnitCode_dictText ?? '', type: 'minUnit' },
];
return {
...parsedContent,
...item,
// 🔧 修复contentJson 中的 totalPrice 优先于 charge_item 表的 totalPrice
// charge_item.totalPrice 可能为 0 或 null新建医嘱时导致总金额显示为 "-"
totalPrice: parsedContent?.totalPrice || item.totalPrice,
isEdit: false,
showPopover: false,
doseQuantity: parsedContent?.doseQuantity,
doseUnitCode_dictText: parsedContent?.doseUnitCode_dictText,
// 确保 unitCode 为字符串类型,与 unitCodeList 的 option value 类型一致
unitCode: String(parsedContent?.unitCode ?? item.unitCode ?? ''),
unitCodeList: unitCodeListData,
// 确保 therapyEnum 被正确设置,优先使用 contentJson 中的值
therapyEnum: String(parsedContent?.therapyEnum ?? item.therapyEnum ?? '1'),
// 🔧 修复:确保 orgId 为 String 类型,与 organization 树的 id 类型一致
@@ -1622,7 +1635,10 @@ function handleSaveGroup(orderGroupList) {
conditionId: conditionId.value,
conditionDefinitionId: conditionDefinitionId.value,
encounterDiagnosisId: encounterDiagnosisId.value,
diagnosisName: diagnosisName.value,
therapyEnum: prescriptionList.value[rowIndex.value]?.therapyEnum || mergedDetail.therapyEnum || '1',
// 🔧 修复:确保组套医嘱的 categoryEnum 被正确映射,防止后端 NPE
categoryEnum: mergedDetail?.categoryEnum || mergedDetail?.categoryCode || item?.categoryCode,
};
// 计算价格和总量
@@ -1663,6 +1679,8 @@ function handleSaveHistory(value) {
encounterDiagnosisId: encounterDiagnosisId.value,
// 确保 therapyEnum 被正确传递,默认为长期医嘱('1')
therapyEnum: value.therapyEnum || '1',
// 🔧 修复:历史医嘱的 categoryCode(String) 映射为后端 categoryEnum(Integer),防止 NPE
categoryEnum: value.categoryEnum || value.categoryCode,
contentJson: JSON.stringify({
...value,
therapyEnum: value.therapyEnum || '1',

View File

@@ -847,26 +847,10 @@ function getPatientList() {
patientId: props.patientId
}
}).then((res) => {
// 判断返回的数据结构
let data = res.data;
if (res.data && res.data.data && typeof res.data.data === 'object') {
// 如果是嵌套结构 {data: {data: Array(3)}}
data = res.data.data;
} else if (res.data && typeof res.data === 'object' && res.data.data !== undefined) {
// 如果是 {code: 200, msg: '操作成功', data: Array(3)}
data = res.data.data;
}
console.log('=== data 长度 ===', data?.length);
if (res.code === 200 && data) {
console.log('=== 准备赋值 patientList.value ===');
patientList.value = data;
console.log('=== patientList.value 赋值后 ===', patientList.value);
console.log('=== patientList.value 长度 ===', patientList.value?.length);
if (res.code === 200 && res.data) {
patientList.value = Array.isArray(res.data) ? res.data : (res.data.data || []);
} else {
console.error('=== 查询失败或无数据 ===');
patientList.value = [];
}
}).catch(err => {
console.error('=== 查询报错 ===', err);
@@ -885,8 +869,22 @@ function getPatientDetial() {
queryParams.value.patientId = props.patientId;
// 默认查询今天的数据
const today = moment().format('YYYY-MM-DD');
const now = moment();
receptionTime.value = [today, today];
formData.value.recordingDate = today;
// 自动填充最近的整点时间点2/6/10/14/18/22点
const hour = now.hour();
const timePoints = [2, 6, 10, 14, 18, 22];
let nearestHour = timePoints[0];
let minDiff = Math.abs(hour - nearestHour);
for (const tp of timePoints) {
const diff = Math.abs(hour - tp);
if (diff < minDiff) {
minDiff = diff;
nearestHour = tp;
}
}
formData.value.timePoint = String(nearestHour).padStart(2, '0') + '00';
// 自动加载数据
getPatientList();
listPatient(queryParams.value).then((res) => {
@@ -967,6 +965,29 @@ function confirmCharge() {
encounterId: props.patientInfo.encounterId,
};
// 自动获取当前日期和时间
const now = moment();
if (!params.recordingDate) {
params.recordingDate = now.format('YYYY-MM-DD');
formData.value.recordingDate = params.recordingDate;
}
if (!params.timePoint) {
// 取最近的整点时间点2/6/10/14/18/22点
const hour = now.hour();
const timePoints = [2, 6, 10, 14, 18, 22];
let nearestHour = timePoints[0];
let minDiff = Math.abs(hour - nearestHour);
for (const tp of timePoints) {
const diff = Math.abs(hour - tp);
if (diff < minDiff) {
minDiff = diff;
nearestHour = tp;
}
}
params.timePoint = String(nearestHour).padStart(2, '0') + '00';
formData.value.timePoint = params.timePoint;
}
// 收集所有录入的体征数据
const vitalSignsCode = [];
const vitalSignsValues = [];
@@ -1052,9 +1073,14 @@ function confirmCharge() {
vitalSignsValues.push(params.stoolVolume);
}
// 校验:没有录入任何体征数据时提示用户
if (vitalSignsCode.length === 0) {
proxy.$modal.msgWarning('请录入患者体征信息');
return;
}
params.vitalSignsCode = vitalSignsCode;
params.vitalSignsValues = vitalSignsValues;
params.recordingDate = formData.value.recordingDate || moment(new Date()).format('YYYY-MM-DD');
addVitalSigns(params).then(res => {
if (res.code === 200) {