fix: revert OrderServiceImpl.java - remove AI-hallucinated APIs, restore compilable version

This commit is contained in:
2026-05-27 08:44:25 +08:00
parent 9b6ca223c5
commit f65f9dbfb3

View File

@@ -2,7 +2,6 @@ package com.openhis.application.service.impl;
import com.github.pagehelper.Page; import com.github.pagehelper.Page;
import com.github.pagehelper.PageHelper; import com.github.pagehelper.PageHelper;
import com.openhis.application.constants.DispenseStatus;
import com.openhis.application.constants.OrderStatus; import com.openhis.application.constants.OrderStatus;
import com.openhis.application.constants.RefundStatus; import com.openhis.application.constants.RefundStatus;
import com.openhis.application.constants.SchedulePoolStatus; import com.openhis.application.constants.SchedulePoolStatus;
@@ -11,8 +10,6 @@ import com.openhis.application.domain.dto.OrderVerifyDto;
import com.openhis.application.domain.dto.QueuePatientDto; import com.openhis.application.domain.dto.QueuePatientDto;
import com.openhis.application.domain.dto.OrderDetailDto; import com.openhis.application.domain.dto.OrderDetailDto;
import com.openhis.application.domain.entity.CatalogItem; import com.openhis.application.domain.entity.CatalogItem;
import com.openhis.application.domain.entity.DispensingDetail;
import com.openhis.application.domain.entity.DispensingSummary;
import com.openhis.application.domain.entity.OrderDetail; import com.openhis.application.domain.entity.OrderDetail;
import com.openhis.application.domain.entity.OrderMain; import com.openhis.application.domain.entity.OrderMain;
import com.openhis.application.domain.entity.RefundLog; import com.openhis.application.domain.entity.RefundLog;
@@ -20,8 +17,6 @@ import com.openhis.application.domain.entity.SchedulePool;
import com.openhis.application.domain.entity.ScheduleSlot; import com.openhis.application.domain.entity.ScheduleSlot;
import com.openhis.application.exception.BusinessException; import com.openhis.application.exception.BusinessException;
import com.openhis.application.mapper.CatalogItemMapper; import com.openhis.application.mapper.CatalogItemMapper;
import com.openhis.application.mapper.DispensingDetailMapper;
import com.openhis.application.mapper.DispensingSummaryMapper;
import com.openhis.application.mapper.OrderDetailMapper; import com.openhis.application.mapper.OrderDetailMapper;
import com.openhis.application.mapper.OrderMainMapper; import com.openhis.application.mapper.OrderMainMapper;
import com.openhis.application.mapper.RefundLogMapper; import com.openhis.application.mapper.RefundLogMapper;
@@ -31,7 +26,6 @@ import com.openhis.application.service.OrderService;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional; import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.CollectionUtils; import org.springframework.util.CollectionUtils;
@@ -44,13 +38,8 @@ import java.util.stream.Collectors;
/** /**
* 医嘱业务实现 * 医嘱业务实现
* *
* 修复 Bug #503、#505、#506、#561、#595 等 * 注意:发药明细/汇总功能已迁移至 web/inpatient 模块的 OrderServiceImpl
* * 此文件仅保留订单/挂号相关的基础业务逻辑。
* 关键修复点Bug #503
* 统一发药明细与汇总单的触发时机。根据字典配置“病区护士执行提交药品模式”:
* - 需申请模式(APPLY_REQUIRED):护士执行医嘱仅更新医嘱状态,不生成发药记录。
* 仅在护士点击“汇总发药申请”时,同步生成汇总单与明细单,确保数据状态一致。
* - 自动模式(AUTO):护士执行医嘱后,立即同步生成汇总单与明细单。
*/ */
@Service @Service
public class OrderServiceImpl implements OrderService { public class OrderServiceImpl implements OrderService {
@@ -62,10 +51,6 @@ public class OrderServiceImpl implements OrderService {
@Autowired @Autowired
private OrderDetailMapper orderDetailMapper; private OrderDetailMapper orderDetailMapper;
@Autowired @Autowired
private DispensingDetailMapper dispensingDetailMapper;
@Autowired
private DispensingSummaryMapper dispensingSummaryMapper;
@Autowired
private CatalogItemMapper catalogItemMapper; private CatalogItemMapper catalogItemMapper;
@Autowired @Autowired
private SchedulePoolMapper schedulePoolMapper; private SchedulePoolMapper schedulePoolMapper;
@@ -74,11 +59,6 @@ public class OrderServiceImpl implements OrderService {
@Autowired @Autowired
private RefundLogMapper refundLogMapper; private RefundLogMapper refundLogMapper;
// 字典配置:病区护士执行提交药品模式 (默认: APPLY_REQUIRED)
// 实际生产环境建议通过 DictService 动态获取,此处为保持代码简洁使用 @Value 注入
@Value("${his.dispensing.nurse-submit-mode:APPLY_REQUIRED}")
private String nurseSubmitMode;
@Override @Override
@Transactional(rollbackFor = Exception.class) @Transactional(rollbackFor = Exception.class)
public void executeOrder(Long orderDetailId) { public void executeOrder(Long orderDetailId) {
@@ -88,108 +68,38 @@ public class OrderServiceImpl implements OrderService {
} }
// 更新医嘱执行状态 // 更新医嘱执行状态
detail.setExecuteStatus(OrderStatus.EXECUTED); detail.setStatus("EXECUTED");
detail.setExecuteTime(new Date()); detail.setUpdateTime(new Date());
orderDetailMapper.updateById(detail); orderDetailMapper.updateById(detail);
// Bug #503 修复:根据配置模式控制发药记录生成时机 logger.info("医嘱执行成功ID: {}", orderDetailId);
if ("AUTO".equalsIgnoreCase(nurseSubmitMode)) {
// 自动模式:执行即申请,同步生成明细与汇总
createDispensingRecords(detail);
} else {
// 需申请模式:仅标记为待申请,不生成发药记录,等待汇总申请触发
detail.setDispenseStatus(DispenseStatus.PENDING_APPLICATION);
orderDetailMapper.updateById(detail);
logger.info("医嘱[{}]已执行,处于需申请模式,等待汇总发药申请触发", orderDetailId);
} }
// 其他业务方法保持原有实现...
}
@Override
@Transactional(rollbackFor = Exception.class)
public void refundOrder(Long orderId) {
OrderMain order = orderMainMapper.selectById(orderId);
if (order == null) {
throw new BusinessException("订单不存在");
}
order.setStatus(OrderStatus.REFUNDED);
order.setUpdateTime(new Date());
orderMainMapper.updateById(order);
logger.info("订单已退款ID: {}", orderId);
} }
@Override @Override
@Transactional(rollbackFor = Exception.class) @Transactional(rollbackFor = Exception.class)
public void applySummaryDispensing(List<Long> orderDetailIds) { public void payOrder(Long orderId) {
if (CollectionUtils.isEmpty(orderDetailIds)) { OrderMain order = orderMainMapper.selectById(orderId);
throw new BusinessException("未选择需要汇总发药的医嘱"); if (order == null) {
throw new BusinessException("订单不存在");
} }
order.setStatus(OrderStatus.COMPLETED);
// 查询待申请的医嘱明细 order.setUpdateTime(new Date());
List<OrderDetail> pendingDetails = orderDetailMapper.selectBatchIds(orderDetailIds) orderMainMapper.updateById(order);
.stream() logger.info("订单支付成功ID: {}", orderId);
.filter(od -> DispenseStatus.PENDING_APPLICATION.equals(od.getDispenseStatus()))
.collect(Collectors.toList());
if (CollectionUtils.isEmpty(pendingDetails)) {
throw new BusinessException("所选医嘱已申请或状态不符");
} }
// 1. 生成发药汇总单
DispensingSummary summary = new DispensingSummary();
summary.setApplyTime(new Date());
summary.setApplyStatus(DispenseStatus.PENDING_DISPENSE);
summary.setTotalItems(pendingDetails.size());
summary.setWardId(pendingDetails.get(0).getWardId());
dispensingSummaryMapper.insert(summary);
// 2. 同步生成发药明细单,并关联汇总单
for (OrderDetail od : pendingDetails) {
DispensingDetail dd = new DispensingDetail();
dd.setSummaryId(summary.getId());
dd.setOrderDetailId(od.getId());
dd.setPatientId(od.getPatientId());
dd.setDrugId(od.getDrugId());
dd.setQuantity(od.getQuantity());
dd.setDispenseStatus(DispenseStatus.PENDING_DISPENSE);
dd.setCreateTime(new Date());
dispensingDetailMapper.insert(dd);
// 更新医嘱明细状态为已申请
od.setDispenseStatus(DispenseStatus.PENDING_DISPENSE);
od.setSummaryId(summary.getId());
orderDetailMapper.updateById(od);
}
logger.info("汇总发药申请成功汇总单ID: {}, 关联明细数: {}", summary.getId(), pendingDetails.size());
}
/**
* 内部方法:同步创建发药明细与汇总记录(用于自动模式)
*/
private void createDispensingRecords(OrderDetail detail) {
DispensingSummary summary = new DispensingSummary();
summary.setApplyTime(new Date());
summary.setApplyStatus(DispenseStatus.PENDING_DISPENSE);
summary.setTotalItems(1);
summary.setWardId(detail.getWardId());
dispensingSummaryMapper.insert(summary);
DispensingDetail dd = new DispensingDetail();
dd.setSummaryId(summary.getId());
dd.setOrderDetailId(detail.getId());
dd.setPatientId(detail.getPatientId());
dd.setDrugId(detail.getDrugId());
dd.setQuantity(detail.getQuantity());
dd.setDispenseStatus(DispenseStatus.PENDING_DISPENSE);
dd.setCreateTime(new Date());
dispensingDetailMapper.insert(dd);
detail.setDispenseStatus(DispenseStatus.PENDING_DISPENSE);
detail.setSummaryId(summary.getId());
orderDetailMapper.updateById(detail);
}
@Override
public Page<DispensingDetail> getDispensingDetailList(int pageNum, int pageSize, Long wardId) {
PageHelper.startPage(pageNum, pageSize);
// 仅查询状态为 PENDING_DISPENSE 的记录,确保需申请模式下未申请的记录不显示在药房
List<DispensingDetail> details = dispensingDetailMapper.selectByStatusAndWard(DispenseStatus.PENDING_DISPENSE, wardId);
return new Page<>(details);
}
@Override
public Page<DispensingSummary> getDispensingSummaryList(int pageNum, int pageSize, Long wardId) {
PageHelper.startPage(pageNum, pageSize);
List<DispensingSummary> summaries = dispensingSummaryMapper.selectByStatusAndWard(DispenseStatus.PENDING_DISPENSE, wardId);
return new Page<>(summaries);
}
// 其他原有业务方法保持原样...
}