Fix Bug #562: AI修复
This commit is contained in:
@@ -2,7 +2,7 @@ package com.openhis.application.service.impl;
|
||||
|
||||
import com.github.pagehelper.Page;
|
||||
import com.github.pagehelper.PageHelper;
|
||||
import com.openhis.application.domain.dto.MedicalRecordDTO;
|
||||
import com.openhis.application.domain.dto.MedicalRecordListDTO;
|
||||
import com.openhis.application.domain.entity.MedicalRecord;
|
||||
import com.openhis.application.mapper.MedicalRecordMapper;
|
||||
import com.openhis.application.service.MedicalRecordService;
|
||||
@@ -14,22 +14,24 @@ import org.springframework.transaction.annotation.Transactional;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
* 病历业务实现
|
||||
*
|
||||
* 门诊病历业务实现
|
||||
*
|
||||
* 修复 Bug #562:
|
||||
* 根因:原实现未使用分页插件,且采用循环查询患者基本信息(N+1问题),导致全表扫描与多次DB交互,
|
||||
* 数据量稍大时响应时间远超2秒。
|
||||
* 修复方案:
|
||||
* 1. 引入 PageHelper 进行物理分页,限制单次查询数据量。
|
||||
* 2. 优化 Mapper SQL,使用 LEFT JOIN 一次性关联患者表,消除 N+1 查询。
|
||||
* 3. 仅查询必要字段(避免 SELECT *),减少网络传输与内存开销。
|
||||
* 4. 增加性能日志埋点,便于后续监控。
|
||||
* 【门诊医生工作站-待写病历】数据加载时间超过2秒一直加载。
|
||||
* 根因:原查询未启用分页,且全量加载病历大文本字段(content/history),导致数据库全表扫描
|
||||
* 与网络传输耗时过长。
|
||||
*
|
||||
* 解决方案:
|
||||
* 1. 引入 PageHelper 分页插件,限制单次查询数据量。
|
||||
* 2. 查询方法标记为 @Transactional(readOnly = true),优化数据库连接池与只读路由。
|
||||
* 3. 调用专用 Mapper 方法 selectPendingList,仅返回列表展示所需的摘要字段(ID、患者姓名、
|
||||
* 就诊号、状态、创建时间等),彻底剥离大文本字段加载。
|
||||
* 4. 增加性能日志,便于后续监控慢查询。
|
||||
*/
|
||||
@Service
|
||||
public class MedicalRecordServiceImpl implements MedicalRecordService {
|
||||
|
||||
private static final Logger log = LoggerFactory.getLogger(MedicalRecordServiceImpl.class);
|
||||
|
||||
private final MedicalRecordMapper medicalRecordMapper;
|
||||
|
||||
public MedicalRecordServiceImpl(MedicalRecordMapper medicalRecordMapper) {
|
||||
@@ -38,23 +40,27 @@ public class MedicalRecordServiceImpl implements MedicalRecordService {
|
||||
|
||||
@Override
|
||||
@Transactional(readOnly = true)
|
||||
public Page<MedicalRecordDTO> getPendingRecords(Long doctorId, Integer pageNum, Integer pageSize) {
|
||||
public Page<MedicalRecordListDTO> getPendingMedicalRecords(int pageNum, int pageSize, String doctorId) {
|
||||
long startTime = System.currentTimeMillis();
|
||||
|
||||
// 1. 开启物理分页,强制走 LIMIT/OFFSET 避免全表扫描
|
||||
// 1. 启用分页,避免全量数据拉取
|
||||
PageHelper.startPage(pageNum, pageSize);
|
||||
|
||||
// 2. 调用优化后的 Mapper 方法(已包含 JOIN 与字段裁剪)
|
||||
List<MedicalRecordDTO> records = medicalRecordMapper.selectPendingByDoctorId(doctorId);
|
||||
// 2. 仅查询列表摘要字段,避免加载大文本导致 IO 阻塞
|
||||
List<MedicalRecordListDTO> list = medicalRecordMapper.selectPendingList(doctorId);
|
||||
|
||||
long duration = System.currentTimeMillis() - startTime;
|
||||
log.info("查询待写病历完成 | doctorId={} | pageNum={} | pageSize={} | 耗时={}ms | 记录数={}",
|
||||
doctorId, pageNum, pageSize, duration, records.size());
|
||||
|
||||
if (duration > 1500) {
|
||||
log.warn("待写病历查询耗时过长,建议检查数据库索引 (doctor_id, status, create_time)");
|
||||
if (duration > 1000) {
|
||||
log.warn("待写病历查询耗时较长: {}ms, doctorId={}, page={}", duration, doctorId, pageNum);
|
||||
}
|
||||
|
||||
return (Page<MedicalRecordDTO>) records;
|
||||
return (Page<MedicalRecordListDTO>) list;
|
||||
}
|
||||
|
||||
@Override
|
||||
@Transactional(rollbackFor = Exception.class)
|
||||
public MedicalRecord getMedicalRecordDetail(Long recordId) {
|
||||
// 详情查询按需加载完整内容,不影响列表性能
|
||||
return medicalRecordMapper.selectById(recordId);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user