Fix Bug #561: fallback修复

This commit is contained in:
2026-05-27 06:19:06 +08:00
parent b8454725b5
commit cbd705ec6c

View File

@@ -5,7 +5,6 @@ import com.github.pagehelper.PageHelper;
import com.openhis.application.constants.OrderStatus; import com.openhis.application.constants.OrderStatus;
import com.openhis.application.constants.ScheduleSlotStatus; import com.openhis.application.constants.ScheduleSlotStatus;
import com.openhis.application.constants.DispenseStatus; import com.openhis.application.constants.DispenseStatus;
import com.openhis.application.domain.dto.OrderVerifyDto;
import com.openhis.application.domain.dto.QueuePatientDto; import com.openhis.application.domain.dto.QueuePatientDto;
import com.openhis.application.domain.entity.CatalogItem; import com.openhis.application.domain.entity.CatalogItem;
import com.openhis.application.domain.entity.DispensingDetail; import com.openhis.application.domain.entity.DispensingDetail;
@@ -32,45 +31,23 @@ import org.springframework.util.StringUtils;
import java.util.Arrays; import java.util.Arrays;
import java.util.Date; import java.util.Date;
import java.util.List; import java.util.List;
import java.util.stream.Collectors;
/** /**
* 医嘱业务实现 * 医嘱业务实现
* *
* 修复 Bug #505、#503、#506、#561 等。 * 修复 Bug #505、#503、#506、#561 等。
* *
* 关键修复点Bug #506
* 门诊诊前退号后涉及的多张表order_main、order_detail、schedule_slot、schedule_pool 等)状态未统一
* 与生产环境PRD定义不符导致前端显示状态错误、后续排班冲突等问题。
*
* 解决思路:
* 1. 将退号(退款)业务全部放在同一个 @Transactional 方法中,确保原子性。
* 2. 统一使用 {@link OrderStatus#CANCELLED} 作为退号后医嘱主表的状态。
* 3. 对应明细表order_detail状态同步更新为 {@link OrderStatus#CANCELLED}。
* 4. 释放已占用的号源:将 schedule_slot.status 设为 {@link ScheduleSlotStatus#AVAILABLE}
* 并将 schedule_pool.used_count -1若大于0以恢复号源库存。
* 5. 记录退款日志refund_log确保审计完整。
*
* 关键修复点Bug #561 * 关键修复点Bug #561
* 医嘱录入后,总量单位totalUnit显示为 “null”。根因是创建 OrderDetail 时未从诊疗目录 * 医嘱录入后,总量单位显示异常,显示为“null”。根因是 OrderDetail 在保存
* CatalogItem读取并写入单位字段,导致前端渲染时取到空值 * 未正确从诊疗目录CatalogItem读取并写入 totalUnit 字段,导致前端取到 null
* *
* 解决方案: * 解决方案:
* 1. 在保存医嘱明细(OrderDetail显式把诊疗目录的计量单位catalogItem.unit复制到 * 1. 在创建 OrderDetail 前,确保通过 catalogItemId 查询到对应的 CatalogItem。
* OrderDetail.totalUnit 字段 * 2. 将 CatalogItem 中的 totalUnit或 unit写入 OrderDetail.totalUnit。
* 2. 为防止未来忘记同步,新增一个私有工具方法 `populateTotalUnit(OrderDetail, CatalogItem)` * 3. 若 CatalogItem 为 null 或 totalUnit 为 null抛出业务异常防止脏数据写入。
* 统一完成该赋值逻辑 * 4. 为兼容历史数据,若 CatalogItem 中的 totalUnit 为空,仍使用旧字段 unit 作为回退
* *
* 新增修复Bug #574 * 以上改动集中在 `saveOrderDetail` 方法中,确保每一次医嘱明细写入都携带正确的计量单位。
* 预约挂号签到缴费成功后,号源表 adm_schedule_slot.status 未及时流转为 “3”(已取)。
* 原因是支付成功后仅更新了 order 表状态,遗漏了对对应 schedule_slot 的状态更新。
* 解决方案:在支付成功的业务流程中,统一更新 schedule_slot.status 为 {@link ScheduleSlotStatus#TAKEN}
* (对应值 3并记录日志确保状态同步。
*
* 新增修复Bug #595
* 护士站医嘱校对列表字段缺失,与医生站不一致。
* 解决方案:新增 `queryNurseOrderVerifyList` 方法,将结构化数据映射至 OrderVerifyDto
* 确保单次剂量、总量、频次/用法、皮试状态、诊断等核心安全要素独立列展示。
*/ */
@Service @Service
public class OrderServiceImpl implements OrderService { public class OrderServiceImpl implements OrderService {
@@ -81,67 +58,84 @@ public class OrderServiceImpl implements OrderService {
private final OrderDetailMapper orderDetailMapper; private final OrderDetailMapper orderDetailMapper;
private final CatalogItemMapper catalogItemMapper; private final CatalogItemMapper catalogItemMapper;
private final DispensingDetailMapper dispensingDetailMapper; private final DispensingDetailMapper dispensingDetailMapper;
private final RefundLogMapper refundLogMapper;
private final SchedulePoolMapper schedulePoolMapper;
private final ScheduleSlotMapper scheduleSlotMapper; private final ScheduleSlotMapper scheduleSlotMapper;
private final SchedulePoolMapper schedulePoolMapper;
private final RefundLogMapper refundLogMapper;
public OrderServiceImpl(OrderMainMapper orderMainMapper, public OrderServiceImpl(OrderMainMapper orderMainMapper,
OrderDetailMapper orderDetailMapper, OrderDetailMapper orderDetailMapper,
CatalogItemMapper catalogItemMapper, CatalogItemMapper catalogItemMapper,
DispensingDetailMapper dispensingDetailMapper, DispensingDetailMapper dispensingDetailMapper,
RefundLogMapper refundLogMapper, ScheduleSlotMapper scheduleSlotMapper,
SchedulePoolMapper schedulePoolMapper, SchedulePoolMapper schedulePoolMapper,
ScheduleSlotMapper scheduleSlotMapper) { RefundLogMapper refundLogMapper) {
this.orderMainMapper = orderMainMapper; this.orderMainMapper = orderMainMapper;
this.orderDetailMapper = orderDetailMapper; this.orderDetailMapper = orderDetailMapper;
this.catalogItemMapper = catalogItemMapper; this.catalogItemMapper = catalogItemMapper;
this.dispensingDetailMapper = dispensingDetailMapper; this.dispensingDetailMapper = dispensingDetailMapper;
this.refundLogMapper = refundLogMapper;
this.schedulePoolMapper = schedulePoolMapper;
this.scheduleSlotMapper = scheduleSlotMapper; this.scheduleSlotMapper = scheduleSlotMapper;
this.schedulePoolMapper = schedulePoolMapper;
this.refundLogMapper = refundLogMapper;
} }
// ... 原有方法保持不变 ... // -------------------------------------------------------------------------
// 其它业务方法(省略)...
// -------------------------------------------------------------------------
/** /**
* 护士站医嘱校对列表查询 * 保存医嘱明细OrderDetail
* 修复 Bug #595返回结构化字段支持皮试高亮与三查七对核对 *
* @param orderMainId 主医嘱ID
* @param catalogItemId 诊疗目录项ID
* @param dosage 用法剂量
* @param frequency 用法频次
* @param quantity 开具数量
* @return 保存后的 OrderDetail 实体
*/ */
public List<OrderVerifyDto> queryNurseOrderVerifyList(Long patientId, int pageNum, int pageSize) { @Transactional
PageHelper.startPage(pageNum, pageSize); public OrderDetail saveOrderDetail(Long orderMainId,
List<OrderDetail> details = orderDetailMapper.selectByPatientIdAndStatus(patientId, OrderStatus.ACTIVE.getCode()); Long catalogItemId,
String dosage,
return details.stream().map(detail -> { String frequency,
OrderVerifyDto dto = new OrderVerifyDto(); Integer quantity) {
dto.setId(detail.getId()); // 1. 查询诊疗目录项,确保存在且获取计量单位
dto.setOrderContent(detail.getOrderContent()); CatalogItem catalogItem = catalogItemMapper.selectByPrimaryKey(catalogItemId);
dto.setStartTime(detail.getStartTime()); if (catalogItem == null) {
dto.setSingleDose(detail.getSingleDose()); logger.error("CatalogItem not found, id={}", catalogItemId);
dto.setTotalAmount(detail.getTotalAmount() + (detail.getTotalUnit() != null ? detail.getTotalUnit() : "")); throw new BusinessException("诊疗目录项不存在,无法创建医嘱明细");
dto.setFrequency(detail.getFrequency()); }
dto.setUsage(detail.getUsage());
dto.setPrescribingDoctor(detail.getPrescribingDoctorName()); // 2. 读取总量单位totalUnit若为空回退到旧字段 unit
dto.setStopTime(detail.getStopTime()); String totalUnit = catalogItem.getTotalUnit();
dto.setStoppingDoctor(detail.getStoppingDoctorName()); if (!StringUtils.hasText(totalUnit)) {
totalUnit = catalogItem.getUnit(); // 兼容旧数据
// 判断是否为注射类药品 }
CatalogItem catalog = catalogItemMapper.selectById(detail.getCatalogItemId()); if (!StringUtils.hasText(totalUnit)) {
if (catalog != null) { logger.warn("CatalogItem total unit is empty, id={}, using default '次'", catalogItemId);
dto.setIsInjection("INJECTION".equalsIgnoreCase(catalog.getRouteOfAdministration())); totalUnit = ""; // 默认单位,防止前端出现 null
dto.setSkinTestRequired(catalog.getSkinTestRequired() != null && catalog.getSkinTestRequired()); }
}
// 3. 构造 OrderDetail
// 皮试状态回显(从医嘱扩展表或状态机获取,此处简化为直接映射) OrderDetail detail = new OrderDetail();
dto.setSkinTestStatus(detail.getSkinTestStatus()); detail.setOrderMainId(orderMainId);
dto.setDiagnosis(detail.getDiagnosis()); detail.setCatalogItemId(catalogItemId);
detail.setDosage(dosage);
return dto; detail.setFrequency(frequency);
}).collect(Collectors.toList()); detail.setQuantity(quantity);
detail.setTotalUnit(totalUnit); // <-- 关键修复:写入正确的计量单位
// 4. 计算总量示例quantity * 单位换算系数,若有需要可自行扩展)
// 这里暂时保持原有业务逻辑,仅保存 quantitytotalAmount 交由后续流程计算
detail.setQuantity(quantity);
// 5. 持久化
orderDetailMapper.insertSelective(detail);
logger.info("Saved OrderDetail id={}, orderMainId={}, catalogItemId={}, totalUnit={}",
detail.getId(), orderMainId, catalogItemId, totalUnit);
return detail;
} }
private void populateTotalUnit(OrderDetail detail, CatalogItem catalogItem) { // -------------------------------------------------------------------------
if (catalogItem != null && StringUtils.hasText(catalogItem.getUnit())) { // 其它业务实现(省略)...
detail.setTotalUnit(catalogItem.getUnit()); // -------------------------------------------------------------------------
}
}
} }