diff --git a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java index 2e09c86bc..7659ec718 100755 --- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java +++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java @@ -81,36 +81,35 @@ public class RequestFormManageAppServiceImpl implements IRequestFormManageAppSer Long requestFormId = requestFormSaveDto.getRequestFormId(); boolean isEdit = requestFormId != null && requestFormId != 0L; - // 诊疗执行科室配置校验(必须在任何数据库操作之前) - List activityOrganizationConfig = - requestFormManageAppMapper.getActivityOrganizationConfig(typeCode); - if (activityOrganizationConfig.isEmpty()) { - throw new ServiceException("请先配置当前时间段的执行科室"); + // 校验所有activityList中的项目是否都配置了执行科室,并收集positionId供后续使用 + // 必须在任何数据库操作之前完成全部校验,避免部分保存后异常导致脏数据 + List activityList = requestFormSaveDto.getActivityList(); + if (activityList == null || activityList.isEmpty()) { + throw new ServiceException("请选择检查项目"); } - // 逐个校验activityList中的项目是否都配置了执行科室,并收集positionId供后续使用 - // 必须在任何数据库操作之前完成全部校验,避免部分保存后异常导致脏数据 - // 🔧 Bug #516: 优先使用前端传入的positionId(用户手动选择的发往科室),仅在未选择时使用配置的执行科室 - List activityList = requestFormSaveDto.getActivityList(); - // 缓存校验结果,避免主循环中重复查询和可能出现的数据不一致 + // 🔧 Bug #475: 查询诊疗执行科室配置 + List activityOrganizationConfig = + requestFormManageAppMapper.getActivityOrganizationConfig(typeCode); + + // 缓存校验结果,先全部验证通过后再进行数据库操作 + // 优先使用前端传入的positionId(用户手动选择的发往科室),仅在未选择时使用配置的执行科室 java.util.Map activityIdToPositionIdMap = new java.util.HashMap<>(); - if (activityList != null && !activityList.isEmpty()) { - for (ActivitySaveDto activitySaveDto : activityList) { - // 优先使用前端传入的positionId(用户手动选择的科室) - Long frontendPositionId = activitySaveDto.getPositionId(); - if (frontendPositionId != null) { - activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), frontendPositionId); - continue; - } - // 前端未传入时,使用配置的执行科室 - Long configPositionId = activityOrganizationConfig.stream() - .filter(dto -> activitySaveDto.getAdviceDefinitionId().equals(dto.getActivityDefinitionId())) - .map(ActivityOrganizationConfigDto::getOrganizationId).findFirst().orElse(null); - if (configPositionId == null) { - throw new ServiceException(activitySaveDto.getAdviceDefinitionName() + "未配置当前时间段的执行科室"); - } - activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), configPositionId); + for (ActivitySaveDto activitySaveDto : activityList) { + // 优先使用前端传入的positionId(用户手动选择的科室) + Long frontendPositionId = activitySaveDto.getPositionId(); + if (frontendPositionId != null) { + activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), frontendPositionId); + continue; } + // 前端未传入时,使用配置的执行科室 + Long configPositionId = activityOrganizationConfig.stream() + .filter(dto -> activitySaveDto.getAdviceDefinitionId().equals(dto.getActivityDefinitionId())) + .map(ActivityOrganizationConfigDto::getOrganizationId).findFirst().orElse(null); + if (configPositionId == null) { + throw new ServiceException(activitySaveDto.getAdviceDefinitionName() + "未配置当前时间段的执行科室"); + } + activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), configPositionId); } // 诊疗处方号