Merge remote-tracking branch 'origin/develop' into develop

2026-05-15 09:44:38 +08:00
parent 610fff704a 0aa7dd9b82
commit 12d0733c0c
26 changed files with 186 additions and 359 deletions
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/appservice/ICommonService.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/appservice/ICommonService.java
@@ -200,10 +200,9 @@ public interface ICommonService {
     * 批号匹配
     *
     * @param encounterIdList 就诊id列表
-     * @param requestIdList 医嘱请求id列表（可选，用于限定仅校验与当前执行医嘱关联的耗材）
     * @return 处理结果
     */
-    R<?> lotNumberMatch(List<Long> encounterIdList, List<Long> requestIdList);
+    R<?> lotNumberMatch(List<Long> encounterIdList);

    /**
     * 根据机构ID获取机构名称
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/appservice/impl/CommonServiceImpl.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/appservice/impl/CommonServiceImpl.java
@@ -39,10 +39,8 @@ import com.openhis.web.common.dto.*;
 import com.openhis.web.common.mapper.CommonAppMapper;
 import com.openhis.web.pharmacymanage.dto.InventoryDetailDto;
 import com.openhis.workflow.domain.DeviceDispense;
-import com.openhis.workflow.domain.DeviceRequest;
 import com.openhis.workflow.domain.InventoryItem;
 import com.openhis.workflow.service.IDeviceDispenseService;
-import com.openhis.workflow.service.IDeviceRequestService;
 import com.openhis.workflow.service.IInventoryItemService;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -101,9 +99,6 @@ public class CommonServiceImpl implements ICommonService {
    @Resource
    private IDeviceDispenseService deviceDispenseService;

-    @Resource
-    private IDeviceRequestService deviceRequestService;
-
    /**
     * 获取药房列表
     *
@@ -683,11 +678,10 @@ public class CommonServiceImpl implements ICommonService {
     * 批号匹配
     *
     * @param encounterIdList 就诊id列表
-     * @param requestIdList 医嘱请求id列表（可选，用于限定仅校验与当前执行医嘱关联的耗材）
     * @return 处理结果
     */
    @Override
-    public R<?> lotNumberMatch(List<Long> encounterIdList, List<Long> requestIdList) {
+    public R<?> lotNumberMatch(List<Long> encounterIdList) {
        // 查询患者待发放的药品信息
        List<MedicationDispense> medicationDispenseList = medicationDispenseService
                .list(new LambdaQueryWrapper<MedicationDispense>().in(MedicationDispense::getEncounterId, encounterIdList)
@@ -804,27 +798,10 @@ public class CommonServiceImpl implements ICommonService {
            }
        }
        // 查询患者待发放的耗材信息
-        LambdaQueryWrapper<DeviceDispense> deviceDispenseQuery = new LambdaQueryWrapper<DeviceDispense>()
-                .in(DeviceDispense::getEncounterId, encounterIdList)
-                .eq(DeviceDispense::getStatusEnum, DispenseStatus.PREPARATION.getValue())
-                .eq(DeviceDispense::getDeleteFlag, DelFlag.NO.getCode());
-        // 若传入requestIdList，则仅查询与指定医嘱请求关联的耗材，避免其他未执行医嘱的耗材记录干扰
-        if (requestIdList != null && !requestIdList.isEmpty()) {
-            List<Long> deviceReqIds = deviceRequestService
-                    .list(new LambdaQueryWrapper<DeviceRequest>()
-                            .in(DeviceRequest::getBasedOnId, requestIdList)
-                            .eq(DeviceRequest::getBasedOnTable, CommonConstants.TableName.WOR_SERVICE_REQUEST))
-                    .stream()
-                    .map(DeviceRequest::getId)
-                    .collect(java.util.stream.Collectors.toList());
-            if (!deviceReqIds.isEmpty()) {
-                deviceDispenseQuery.in(DeviceDispense::getDeviceReqId, deviceReqIds);
-            } else {
-                // 无关联的耗材请求，直接跳过耗材校验
-                deviceDispenseQuery.eq(DeviceDispense::getId, -1L);
-            }
-        }
-        List<DeviceDispense> deviceDispenseList = deviceDispenseService.list(deviceDispenseQuery);
+        List<DeviceDispense> deviceDispenseList = deviceDispenseService
+                .list(new LambdaQueryWrapper<DeviceDispense>().in(DeviceDispense::getEncounterId, encounterIdList)
+                        .eq(DeviceDispense::getStatusEnum, DispenseStatus.PREPARATION.getValue())
+                        .eq(DeviceDispense::getDeleteFlag, DelFlag.NO.getCode()));
        // 耗材批号匹配
        if (deviceDispenseList != null && !deviceDispenseList.isEmpty()) {
            // 获取待发放的耗材id
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/controller/CommonAppController.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/common/controller/CommonAppController.java
@@ -274,13 +274,10 @@ public class CommonAppController {
     * 批号匹配
     *
     * @param encounterIdList 就诊id列表
-     * @param requestIdList 医嘱请求id列表（可选，用于限定仅校验与当前执行医嘱关联的耗材）
     * @return 处理结果
     */
    @GetMapping("/lot-number-match")
-    public R<?> lotNumberMatch(
-            @RequestParam(value = "encounterIdList") List<Long> encounterIdList,
-            @RequestParam(value = "requestIdList", required = false) List<Long> requestIdList) {
-        return commonService.lotNumberMatch(encounterIdList, requestIdList);
+    public R<?> lotNumberMatch(@RequestParam(value = "encounterIdList") List<Long> encounterIdList) {
+        return commonService.lotNumberMatch(encounterIdList);
    }
 }
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/doctorstation/appservice/impl/DoctorStationAdviceAppServiceImpl.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/doctorstation/appservice/impl/DoctorStationAdviceAppServiceImpl.java
@@ -728,12 +728,8 @@ public class DoctorStationAdviceAppServiceImpl implements IDoctorStationAdviceAp

            /**
             * 处理耗材请求
-             * 🔧 BugFix #443: 签发时跳过 handDevice，避免重复创建 DeviceDispense 并覆盖关键字段（如 performLocation）
-             * 签发时只需更新状态（下方 sign-advice 批量更新逻辑已处理）
             */
-            if (AdviceOpType.SAVE_ADVICE.getCode().equals(adviceOpType)) {
-                this.handDevice(deviceList, curDate, adviceOpType);
-            }
+            this.handDevice(deviceList, curDate, adviceOpType);

            // 签发时,把草稿状态的账单更新为待收费
            if (AdviceOpType.SIGN_ADVICE.getCode().equals(adviceOpType) && !adviceSaveList.isEmpty()) {
@@ -2107,9 +2103,11 @@ public class DoctorStationAdviceAppServiceImpl implements IDoctorStationAdviceAp
                CommonConstants.TableName.MED_MEDICATION_REQUEST, CommonConstants.TableName.WOR_DEVICE_REQUEST,
                CommonConstants.TableName.WOR_SERVICE_REQUEST, practitionerId, Whether.NO.getCode(),
                sourceEnum, sourceBillNo);
-        // 🔧 修复 Bug #444: 移除手术计费场景的药品过滤。
-        // 原过滤会导致门诊手术医嘱界面无法获取手术计费创建的药品记录。
-        // 前端各组件已根据自身业务逻辑做了正确的 adviceType 过滤。
+        // 手术计费场景：sourceBillNo 不为空时，过滤掉药品（1），保留耗材（2）和诊疗（3/6）
+        if (sourceBillNo != null && !sourceBillNo.isEmpty()) {
+            requestBaseInfo.removeIf(dto -> dto.getAdviceType() != null
+                    && dto.getAdviceType() == 1);
+        }
        for (RequestBaseDto requestBaseDto : requestBaseInfo) {
            // 请求状态
            requestBaseDto
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/doctorstation/appservice/impl/DoctorStationDiagnosisAppServiceImpl.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/doctorstation/appservice/impl/DoctorStationDiagnosisAppServiceImpl.java
@@ -246,8 +246,7 @@ public class DoctorStationDiagnosisAppServiceImpl implements IDoctorStationDiagn
        EncounterDiagnosis encounterDiagnosis;
        for (SaveDiagnosisChildParam saveDiagnosisChildParam : diagnosisChildList) {
            encounterDiagnosis = new EncounterDiagnosis();
-            // 注意：不设置 encounterDiagnosisId，因为上面已经删除了所有记录
-            // 如果设置旧的 ID，saveOrUpdate 会尝试 UPDATE 不存在的记录导致失败或重复插入
+            encounterDiagnosis.setId(saveDiagnosisChildParam.getEncounterDiagnosisId());
            encounterDiagnosis.setEncounterId(encounterId);
            encounterDiagnosis.setConditionId(saveDiagnosisChildParam.getConditionId());
            encounterDiagnosis.setMaindiseFlag(saveDiagnosisChildParam.getMaindiseFlag());
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/appservice/impl/AdviceProcessAppServiceImpl.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/appservice/impl/AdviceProcessAppServiceImpl.java
@@ -178,7 +178,7 @@ public class AdviceProcessAppServiceImpl implements IAdviceProcessAppService {
        inpatientAdviceParam.setEncounterIds(null);
        Integer exeStatus = inpatientAdviceParam.getExeStatus();
        inpatientAdviceParam.setExeStatus(null);
-        Integer requestStatus = inpatientAdviceParam.getRequestStatus();
+        // requestStatus由前端tab控制，后端SQL已通过CASE条件处理校对状态过滤，无需再作为SQL条件
        inpatientAdviceParam.setRequestStatus(null);
        // 构建查询条件
        QueryWrapper<InpatientAdviceParam> queryWrapper
@@ -198,7 +198,7 @@ public class AdviceProcessAppServiceImpl implements IAdviceProcessAppService {
                        ParticipantType.ADMITTING_DOCTOR.getCode(), AccountType.PERSONAL_CASH_ACCOUNT.getCode(),
                        ChargeItemStatus.BILLABLE.getValue(), ChargeItemStatus.BILLED.getValue(),
                        ChargeItemStatus.REFUNDED.getValue(), EncounterClass.IMP.getValue(),
-                        GenerateSource.DOCTOR_PRESCRIPTION.getValue(), requestStatus);
+                        GenerateSource.DOCTOR_PRESCRIPTION.getValue());
        inpatientAdvicePage.getRecords().forEach(e -> {
            // 是否皮试
            e.setSkinTestFlag_enumText(EnumUtils.getInfoByValue(Whether.class, e.getSkinTestFlag()));
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/dto/InpatientAdviceDto.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/dto/InpatientAdviceDto.java
@@ -245,7 +245,7 @@ public class InpatientAdviceDto {
    /**
     * 药品/服务类型
     */
-    private Integer categoryCode;
+    private String categoryCode;
    /**
     * 执行科室
     */
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/mapper/AdviceProcessAppMapper.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/inhospitalnursestation/mapper/AdviceProcessAppMapper.java
@@ -69,6 +69,5 @@ public interface AdviceProcessAppMapper {
        @Param("active") Integer active, @Param("bed") Integer bed, @Param("admittingDoctor") String admittingDoctor,
        @Param("personalCashAccount") String personalCashAccount, @Param("billable") Integer billable,
        @Param("billed") Integer billed, @Param("refunded") Integer refunded, @Param("imp") Integer imp,
-        @Param("doctorPrescription") Integer doctorPrescription,
-        @Param("requestStatus") Integer requestStatus);
+        @Param("doctorPrescription") Integer doctorPrescription);
 }
--- a/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java
+++ b/openhis-server-new/openhis-application/src/main/java/com/openhis/web/regdoctorstation/appservice/impl/RequestFormManageAppServiceImpl.java
@@ -81,35 +81,36 @@ public class RequestFormManageAppServiceImpl implements IRequestFormManageAppSer
        Long requestFormId = requestFormSaveDto.getRequestFormId();
        boolean isEdit = requestFormId != null && requestFormId != 0L;

-        // 校验所有activityList中的项目是否都配置了执行科室，并收集positionId供后续使用
-        // 必须在任何数据库操作之前完成全部校验，避免部分保存后异常导致脏数据
-        List<ActivitySaveDto> activityList = requestFormSaveDto.getActivityList();
-        if (activityList == null || activityList.isEmpty()) {
-            throw new ServiceException("请选择检查项目");
-        }
-
-        // 🔧 Bug #475: 查询诊疗执行科室配置
+        // 诊疗执行科室配置校验（必须在任何数据库操作之前）
        List<ActivityOrganizationConfigDto> activityOrganizationConfig =
            requestFormManageAppMapper.getActivityOrganizationConfig(typeCode);
+        if (activityOrganizationConfig.isEmpty()) {
+            throw new ServiceException("请先配置当前时间段的执行科室");
+        }

-        // 缓存校验结果，先全部验证通过后再进行数据库操作
-        // 优先使用前端传入的positionId（用户手动选择的发往科室），仅在未选择时使用配置的执行科室
+        // 逐个校验activityList中的项目是否都配置了执行科室，并收集positionId供后续使用
+        // 必须在任何数据库操作之前完成全部校验，避免部分保存后异常导致脏数据
+        // 🔧 Bug #516: 优先使用前端传入的positionId（用户手动选择的发往科室），仅在未选择时使用配置的执行科室
+        List<ActivitySaveDto> activityList = requestFormSaveDto.getActivityList();
+        // 缓存校验结果，避免主循环中重复查询和可能出现的数据不一致
        java.util.Map<Long, Long> activityIdToPositionIdMap = new java.util.HashMap<>();
-        for (ActivitySaveDto activitySaveDto : activityList) {
-            // 优先使用前端传入的positionId（用户手动选择的科室）
-            Long frontendPositionId = activitySaveDto.getPositionId();
-            if (frontendPositionId != null) {
-                activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), frontendPositionId);
-                continue;
+        if (activityList != null && !activityList.isEmpty()) {
+            for (ActivitySaveDto activitySaveDto : activityList) {
+                // 优先使用前端传入的positionId（用户手动选择的科室）
+                Long frontendPositionId = activitySaveDto.getPositionId();
+                if (frontendPositionId != null) {
+                    activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), frontendPositionId);
+                    continue;
+                }
+                // 前端未传入时，使用配置的执行科室
+                Long configPositionId = activityOrganizationConfig.stream()
+                    .filter(dto -> activitySaveDto.getAdviceDefinitionId().equals(dto.getActivityDefinitionId()))
+                    .map(ActivityOrganizationConfigDto::getOrganizationId).findFirst().orElse(null);
+                if (configPositionId == null) {
+                    throw new ServiceException(activitySaveDto.getAdviceDefinitionName() + "未配置当前时间段的执行科室");
+                }
+                activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), configPositionId);
            }
-            // 前端未传入时，使用配置的执行科室
-            Long configPositionId = activityOrganizationConfig.stream()
-                .filter(dto -> activitySaveDto.getAdviceDefinitionId().equals(dto.getActivityDefinitionId()))
-                .map(ActivityOrganizationConfigDto::getOrganizationId).findFirst().orElse(null);
-            if (configPositionId == null) {
-                throw new ServiceException(activitySaveDto.getAdviceDefinitionName() + "未配置当前时间段的执行科室");
-            }
-            activityIdToPositionIdMap.put(activitySaveDto.getAdviceDefinitionId(), configPositionId);
        }

        // 诊疗处方号